dubee commented on a change in pull request #3503: move CLI node tests to CLI
repo and sync node default tests
URL:
https://github.com/apache/incubator-openwhisk/pull/3503#discussion_r178657257
##########
File path: tests/src/test/scala/system/basic/WskRuleTests.scala
##########
@@ -102,21 +103,28 @@ abstract class WskRuleTests extends TestHelpers with
WskTestHelpers {
case (trigger, status) =>
if (status == active) wsk.rule.enable(ruleName) else
wsk.rule.disable(ruleName)
- // Needs to be retried since the enable/disable causes a cache
invalidation which needs to propagate first
- retry(
- {
- wsk.rule
- .create(ruleName, trigger, actionName, update = true)
- .stdout
- .parseJson
- .asJsObject
- .fields
- .get("status") shouldBe status
-
-
wsk.rule.get(ruleName).stdout.parseJson.asJsObject.fields.get("status")
shouldBe status
- },
- 10,
- Some(1.second))
+ if (cli) {
Review comment:
As part of future work, the base tests shouldn't know or care whether the
the REST or CLI is being used. We should be able to provide a special function
to strip out the CLI header that have the same interface that the REST tests
use to prevent adding this special logic in the base tests. Maybe we can
override RunResult for the CLI tests that has a method that removes the header.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
