jonpspri opened a new pull request #3534: Add abstraction to controller role URL: https://github.com/apache/incubator-openwhisk/pull/3534 ## Description Add a level of abstraction the controller role. It will now accept a set of parameters to configure: 1. `host_group` - the group from the hosts file used to determine indexing during deployment 2. `name_prefix` - the prefix (i.e. 'controller', 'crudController') used to name docker instances 3. `controller_index_base` - the base starting point for indexing in the total controller arrays While working on #3412, it was uncovered that some (or at least one major) implementers of OpenWhisk segregate their controllers and use a copy of the rolefile to deploy it. That creates maintenance overhead and deployment complexity in keeping ansible playbooks in sync. This change abstracts the necessary parameters to allow the OpenWhisk playbook to be used to deploy multiple 'collections' of controllers into an environment. The change also includes significant linting of 'roles/controller/tasks/deploy.yml' and '.../clean.yml' to support maintainability and readability. ## Related issue and scope <!--- Please include a link to a related issue if there is one. --> - [ ] I opened an issue to propose and discuss this change (#????) ## My changes affect the following components <!--- Select below all system components are affected by your change. --> <!--- Enter an `x` in all applicable boxes. --> - [ ] API - [X] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [X] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: --> - [ ] Bug fix (generally a non-breaking change which closes an issue). - [X] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. --> - [X] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services