ddragosd commented on a change in pull request #3199: One tid for the whole
system.
URL:
https://github.com/apache/incubator-openwhisk/pull/3199#discussion_r180452384
##########
File path: ansible/roles/nginx/templates/nginx.conf.j2
##########
@@ -12,10 +12,16 @@ http {
{# allow large uploads, need to thread proper limit into here #}
client_max_body_size 50M;
+ map $http_ow_tid $ow_tid {
Review comment:
@sven-lange-last 👍 NGINX's `request_id` should do it as well. I've been
using the other `set_secure_random_alphanum` in the past years ( before NGINX
1.11.x added `request_id` ) and the performance implications were not visible.
One thing to consider here is that OW should accept a variable length for
this ID ( which IMHO should be fine) b/c NGINX might update this in the future;
I'm not aware of a way to configure the size `16` or `32` or another size,
unlike with the older `set_secure....`; Note that the article referenced says
it's 32 chars, while the
[docs](http://nginx.org/en/docs/http/ngx_http_core_module.html) say it's 16.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
