bbrowning commented on issue #2855: Cache database attachments
URL: 
https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-381577307
 
 
   @markusthoemmes To answer your question above - yes, this change caches 
attachments in the controller as well. @chetanmeh mentioned in Slack that he'd 
like to followup on this change with another set of changes to cache 
attachments only in the Invoker and to store cached attachments on the 
filesystem instead of JVM heap.
   
   That second point - the fact that caches are stored in the heap - would be 
my only other concern in merging this patch. For environments with a limited 
number of functions this change isn't a big deal. But, if your OpenWhisk 
installation has many thousands of different functions that get invoked within 
the current 5 minute cache timeout then this may be an issue.
   
   Until or unless we test filesystem-based attachment caching, we may want to 
set a `maximumWeight` or `maximumSize` on the `Caffeine` cache instances so 
that cached attachments get evicted before relying on the JVM garbage 
collection of soft references and/or expiration time.
   
   In my opinion, the performance improvement for Java functions under load is 
worth figuring out these other details.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to