tysonnorris commented on issue #3232: Making prewarm kind (and count) 
configurable
URL: 
https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-384467242
 
 
   I think it would be useful to have both per-kind and multiple. Obviously we 
can't guess all the variants that will be used realistically, but implementing 
these gives significant flexibility, e.g. to tune the deployment to have lots 
of small prewarm, plus a few large ones, etc. 
   
   The potential problem for multiple prewarms that vary by memory is that you 
may end up running "small" (memory footprint) actions on a "large" container, 
if you only test whether the action memory < prewarm memory. This may have some 
odd results, like creating many large footprint containers that are only used 
for small actions, and causing large actions to wait for cold starts. 
   
   It may be worthwhile to add another config property, like `minMemory` where 
the prewarm will ONLY be used if `prewarm.minMemory < action.limits.memory < 
prewarm.memory'. In this case, you could have a few large prewarms around, that 
will actually be reserved for running actions that are close in memory 
footprint requirements. 
   
   In the spirit of "change it once", this may be a good time to introduce 
action resource attributes as well. I think this is needed in actions so that, 
for example, an action can signal that it needs to run on a gpu host, or 
consumes a relatively large amount of cpu, etc. If an action can signal these, 
they will need to be configurations within the runtime manifest as well. This 
is a bigger change though, so may be worthwhile to settle for "change it 
twice"? I will open up an issue for this (if one doesn't exist)
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to