mrutkows commented on issue #194: Adopt latest scancode ASF release config. (enforce *.md, .conf, .sh). URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/194#issuecomment-388388278 @csantanapr likely we should be doing less in setup.sh (i.e., during the "before_install" phase). Typically, we place scancode as the first step under the (build) "script" step, once all the code is laid out/marshalled/extracted, etc. I would like to make it earlier by convention, but it seemed that was the existing convention (already in place) and meant to assure that dependencies (if there were any) could also get scanned if people wanted. In any event, we should have separation of dependencies/tools that are laid down (not unzip/untar) directly under home) which Dave has been making sure of with push/pop like he did for the Helm stuff.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
