rabbah commented on a change in pull request #3644: Allow more special
characters in EntityName.
URL:
https://github.com/apache/incubator-openwhisk/pull/3644#discussion_r187648510
##########
File path: common/scala/src/main/scala/whisk/core/entity/EntityPath.scala
##########
@@ -189,13 +189,15 @@ protected[core] class EntityName private (val name:
String) extends AnyVal {
protected[core] object EntityName {
protected[core] val ENTITY_NAME_MAX_LENGTH = 256
+ protected[core] val allowedSpecialCharacters = "@.&%!?=#-"
Review comment:
https://github.com/apache/incubator-openwhisk/issues/2830
rather than more arbitrary characters - since this isn't the first time the
list has gotten larger, how about allowing the largest set of characters
instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
