markusthoemmes commented on a change in pull request #3644: Allow more special
characters in EntityName.
URL:
https://github.com/apache/incubator-openwhisk/pull/3644#discussion_r187648786
##########
File path: common/scala/src/main/scala/whisk/core/entity/EntityPath.scala
##########
@@ -189,13 +189,15 @@ protected[core] class EntityName private (val name:
String) extends AnyVal {
protected[core] object EntityName {
protected[core] val ENTITY_NAME_MAX_LENGTH = 256
+ protected[core] val allowedSpecialCharacters = "@.&%!?=#-"
Review comment:
proposing:
```
protected[core] val REGEX =
raw"\A([a-zA-Z0-9]|[a-zA-Z0-9][^/]{0,${ENTITY_NAME_MAX_LENGTH - 2}}[^/ ])\z"
```
Will allow anything but "/" since that gets nasty in URLs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
