eweiter commented on a change in pull request #59: implement temporary workaround to issue_3646, swift 4.1 bug with structs URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/59#discussion_r187784034
########## File path: tools/build/compile.sh ########## @@ -43,7 +43,9 @@ else fi DEST_PACKAGE_SWIFT="$BASE_PATH/spm-build/Package.swift" -BUILD_FLAGS="" +# Due to a current bug in the Swift Docker image compile optimization is disabled by default. +# If you need compiler optimization you can override the BUILD_FLAGS to enable it +BUILD_FLAGS="-Xswiftc -Onone" Review comment: @csantanapr I was thinking of limiting this to solely the Swift 4.1 runtime. What do you think about that? I tested that it has no adverse effects on Swift 3.1.1, but I didn't know since it is a Swift 4.1 fix if we should limit it to only that scope. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
