tysonnorris commented on a change in pull request #3562: ArtifactStore
implementation for CosmosDB
URL:
https://github.com/apache/incubator-openwhisk/pull/3562#discussion_r189416561
##########
File path: common/scala/build.gradle
##########
@@ -47,6 +47,10 @@ dependencies {
compile 'io.kamon:kamon-statsd_2.11:0.6.7'
//for mesos
compile 'com.adobe.api.platform.runtime:mesos-actor:0.0.7'
+
+ compile 'io.reactivex:rxscala_2.11:0.26.5'
+ compile 'io.reactivex:rxjava-reactive-streams:1.2.1'
+ compile 'com.microsoft.azure:azure-cosmosdb:1.0.0'
Review comment:
Only concern is the jump in netty version - when I build controller.tar from
your branch I get both netty versions:
```tnorris@tnorris-macOS
~/git/forks/adobe-apiplatform/incubator-openwhisk-mac -
(chetanmeh-artifact-store-cosmos) $ tar -tvf
core/controller/build/distributions/controller.tar | grep netty
-rw-r--r-- 0 0 0 413674 May 18 13:27
controller/lib/rxnetty-0.4.20.jar
-rw-r--r-- 0 0 0 562559 May 18 13:27
controller/lib/netty-codec-http-4.1.22.Final.jar
-rw-r--r-- 0 0 0 374389 May 18 13:27
controller/lib/netty-handler-4.1.22.Final.jar
-rw-r--r-- 0 0 0 316316 May 18 13:27
controller/lib/netty-codec-4.1.22.Final.jar
-rw-r--r-- 0 0 0 456605 May 18 13:27
controller/lib/netty-transport-4.1.22.Final.jar
-rw-r--r-- 0 0 0 270720 May 18 13:27
controller/lib/netty-buffer-4.1.22.Final.jar
-rw-r--r-- 0 0 0 32276 May 18 13:27
controller/lib/netty-resolver-4.1.22.Final.jar
-rw-r--r-- 0 0 0 575748 May 18 13:27
controller/lib/netty-common-4.1.22.Final.jar
-rw-r--r-- 0 0 0 1292696 Sep 13 2017
controller/lib/netty-3.10.6.Final.jar
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
