chetanmeh commented on a change in pull request #3689: Enable extending
environment variables of Controller and Invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3689#discussion_r190155278
##########
File path: ansible/roles/controller/tasks/deploy.yml
##########
@@ -236,6 +236,14 @@
"CONFIG_whisk_transactions_header": "{{ transactions.header }}"
+- name: merge extra env variables
+ set_fact:
+ controller_env: "{{ controller_env | default({}) | combine(item) }}"
+ with_items: "{{ extraEnvSets.split(',') | map('trim') | map('extract',
vars)| list }}"
+ loop_control:
+ label: redacted
Review comment:
Ansible would by default emit the item value to stdout. As the values may
contain secrets set the label to a constant
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
