chetanmeh commented on a change in pull request #2282: Distributed tracing 
support #2192
URL: 
https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r190799810
 
 

 ##########
 File path: 
core/controller/src/main/scala/whisk/core/controller/Controller.scala
 ##########
 @@ -203,6 +204,7 @@ object Controller {
     // if deploying multiple instances (scale out), must pass the instance 
number as the
     require(args.length >= 1, "controller instance required")
     val instance = args(0).toInt
+    OpenTracingProvider.apply("Controller")
 
 Review comment:
   Instead of having controller and invoker initialize the tracer it would be 
better to capture the name as part of config itself. Then you can specify the 
name in reference.conf of invoker and controller and no need for any explicit 
initialization call

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to