chetanmeh commented on a change in pull request #3709: Inlined attachments
URL:
https://github.com/apache/incubator-openwhisk/pull/3709#discussion_r191175717
##########
File path: common/scala/src/main/resources/application.conf
##########
@@ -114,6 +114,14 @@ whisk {
actions-ddoc = "whisks.v2.1.0"
activations-ddoc = "whisks.v2.1.0"
activations-filter-ddoc = "whisks-filters.v2.1.0"
+
+ # Size limit for inlined attachments. Attachments having size less
than this would
+ # be inlined with there content encoded in attachmentName
+ max-inline-size = 16 k
+
+ # Chunk sized for converting source of bytes to ByteString as part of
attachment
+ # upload flow
+ chunk-size = 8 k
Review comment:
Value of 8k is choosed based on default used by
[StreamConverters.fromInputStream][1] which is used by `DocumentFactory` to
create a `Source[ByteString,_]` from `InputStream` currently
[1]:
https://github.com/akka/akka/blob/master/akka-stream/src/main/scala/akka/stream/scaladsl/StreamConverters.scala#L48
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services