sven-lange-last opened a new pull request #3710: Make REST communication with 
action containers more robust
URL: https://github.com/apache/incubator-openwhisk/pull/3710
 
 
   On systems with high load, POSTing the action container `/init` endpoint 
occasionally fails with `NoRouteToHostException`. Retry if this exception 
occurs.
   
   ## Description
   * So far, the HTTP client retried when the connection to an action container 
failed with `HttpHostConnectException`. This is safe because no data has been 
transmitted yet when this exception occurs. Usually, this exception will occur 
if the action container startup is slow such that the target socket is not 
listening yet.
   * This change adds `NoRouteToHostException` as retryable exception. Root 
cause for this exception is high system load. It is safe to retry after this 
exception occurred because it implies that no data has been transmitted yet.
   * Needed to restructure the code to add the second retryable exception.
   * Lowered the time between retries from 100 ms to 10 ms because this shorter 
time should be sufficient to have routing available / the target socket 
listening.
   * Added logging so that retries can be seen in system logs.
   
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   - [ ] I opened an issue to propose and discuss this change (#????)
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [x] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the 
boxes that apply: -->
   - [x] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered 
all aspects of the change you're making. -->
   
   - [x] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to