dgrove-oss commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193573246
##########
File path: common/scala/src/main/scala/whisk/core/entity/InstanceId.scala
##########
@@ -22,7 +22,20 @@ import spray.json.DefaultJsonProtocol
case class InstanceId(val instance: Int, name: Option[String] = None) {
def toInt: Int = instance
}
-
+case class StringInstanceId(instance: String) {
Review comment:
Sorry, late to the party.
I agree we still need both --name and --id independent of whether they are
of type String or Int unless we want to make some deeper changes in the
loadbalancer. Might be nice to try to simplify at some point, but I don't
think it is worth holding up this PR to accomplish it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
