chetanmeh commented on a change in pull request #3722: Scala based admin tooling URL: https://github.com/apache/incubator-openwhisk/pull/3722#discussion_r193959878
########## File path: core/admin/src/main/scala/whisk/core/cli/Main.scala ########## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package whisk.core.cli + +import java.io.File + +import akka.actor.ActorSystem +import akka.stream.ActorMaterializer +import ch.qos.logback.classic.{Level, LoggerContext} +import org.rogach.scallop._ +import org.slf4j.LoggerFactory +import pureconfig.error.ConfigReaderException +import whisk.common.{AkkaLogging, Logging, TransactionId} +import whisk.core.database.UserCommand + +import scala.concurrent.duration.DurationInt +import scala.concurrent.{Await, Future} +import scala.util.{Failure, Success, Try} + +class Conf(arguments: Seq[String]) extends ScallopConf(arguments) { + banner("OpenWhisk admin command line tool") + + val verbose = tally() + val configFile = opt[File](descr = "application.conf path") Review comment: No specific reason. So. far I was thinking that we "publish" the tool jar to maven/github release and then admins can just download the jar and need not checkout whole of openwhisk repo to run the admin commands. In such a case they would need to provide a custom conf Thinking about it it now it would be fine to support that. This may require following changes 1. Capture `ArtifactStore` settings as part of group vars 2. Have a `application.conf.j2` with some templating logic to render different config based on store type 3. Have it copied to std place say `${OPENWHISK_HOME}/whisk-cli.conf` or put it under `${OPENWHISK_HOME}/bin/whisk-cli.conf` 4. Have the tooling look there by default ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
