rabbah commented on a change in pull request #311: Display appropriate message
for trigger fire when 204 is returned
URL:
https://github.com/apache/incubator-openwhisk-cli/pull/311#discussion_r194896146
##########
File path: commands/trigger.go
##########
@@ -92,13 +92,24 @@ var triggerFireCmd = &cobra.Command{
return werr
}
+ if resp.StatusCode == 204 {
+ fmt.Fprintf(color.Output,
+ wski18n.T("trigger /{{.namespace}}/{{.name}}
did not fire as it is not associated with an active rule(s)\n",
+ map[string]interface{}{
+ "namespace":
boldString(qualifiedName.GetNamespace()),
+ "name":
boldString(qualifiedName.GetEntityName())}))
+
+ return nil
Review comment:
which exit code would you return?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
