rabbah commented on a change in pull request #3552: Emit activation metadata to
Kafka
URL:
https://github.com/apache/incubator-openwhisk/pull/3552#discussion_r197094941
##########
File path: core/invoker/src/main/scala/whisk/core/invoker/InvokerReactive.scala
##########
@@ -112,19 +113,43 @@ class InvokerReactive(
private val ack = (tid: TransactionId,
activationResult: WhiskActivation,
blockingInvoke: Boolean,
- controllerInstance: InstanceId) => {
+ controllerInstance: InstanceId,
+ userId: UUID) => {
implicit val transid: TransactionId = tid
def send(res: Either[ActivationId, WhiskActivation], recovery: Boolean =
false) = {
val msg = CompletionMessage(transid, res, instance)
-
producer.send(s"completed${controllerInstance.toInt}", msg).andThen {
case Success(_) =>
logging.info(
this,
s"posted ${if (recovery) "recovery" else "completion"} of
activation ${activationResult.activationId}")
}
}
+ // Potentially sends activation metadata to kafka if user events are
enabled
+ UserEvents.send(
+ producer, {
+ val activation = Activation(
Review comment:
this `Activation` type is better served as a method in `WhiskActivation`
instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
