tysonnorris commented on a change in pull request #3789: Refactoring the load balancer with an overflow queue to reduce activation waiting time URL: https://github.com/apache/incubator-openwhisk/pull/3789#discussion_r197324884
########## File path: core/controller/src/main/scala/whisk/core/loadBalancer/ShardingContainerPoolBalancer.scala ########## @@ -74,6 +73,9 @@ class ShardingContainerPoolBalancer(config: WhiskConfig, controllerInstance: Ins private val activationsPerNamespace = TrieMap[UUID, LongAdder]() private val totalActivations = new LongAdder() + var localOverflowActivationCount: Int = 0 Review comment: If the topic receives messages from multiple controllers, this count won't reflect whether there are messages left in the topic, I think? For example, if another controller consumes ALL the overflow messages, will this controller be left indefinitely with localOverflowActivationCount > 0? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
