chetanmeh commented on issue #3286: Treat action code as attachments for 
created/updated actions
URL: 
https://github.com/apache/incubator-openwhisk/pull/3286#issuecomment-403190287
 
 
   @dubee  Do you plan to work on this otherwise I can look into it. Given 
recent changes in master the `ArtifactStore` does not make use of 
attachmentName attribute from manifest. So was thinking to do away with 
manifest entry for name attribute.
   
   For attachment type I am not sure - For e.g. if its a simple code snippet 
then type can be `text/plain` otherwise if its a zip (say js code packaged as 
zip) then it would be `application/octet-stream`.
   
   Further with inlining support now we can **always** store the code for all 
kinds as attachments by design and let `ArtifactStore` inline the binary if its 
small. So no need to different between attachment for various kinds

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to