rabbah commented on a change in pull request #3855: Add invoker container name
to health protocol
URL:
https://github.com/apache/incubator-openwhisk/pull/3855#discussion_r200966899
##########
File path:
core/controller/src/main/scala/whisk/core/loadBalancer/ShardingContainerPoolBalancer.scala
##########
@@ -291,7 +291,9 @@ class ShardingContainerPoolBalancer(config: WhiskConfig,
controllerInstance: Con
val start = transid.started(
this,
LoggingMarkers.CONTROLLER_KAFKA,
- s"posting topic '$topic' with activation id '${msg.activationId}'",
+ invoker.hostname
+ .map(h => s"posting topic '$topic' to invoker '$h' with activation id
'${msg.activationId}'")
+ .getOrElse(s"posting topic '$topic' with activation id
'${msg.activationId}'"),
Review comment:
Can you fold the logic for printing the name into the invoker instance id
instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
