markusthoemmes commented on a change in pull request #3799: Display proper
error when sequence invocation fails due to missing component
URL:
https://github.com/apache/incubator-openwhisk/pull/3799#discussion_r201824175
##########
File path: tests/src/test/scala/system/basic/WskSequenceTests.scala
##########
@@ -48,6 +49,26 @@ class WskSequenceTests extends TestHelpers with
WskTestHelpers with StreamLoggin
behavior of "Wsk Sequence"
+ it should "produce proper error when sequence component does not exist" in
withAssetCleaner(wskprops) {
+ (wp, assetHelper) =>
+ val seqCompName = "seqComp"
+ val seqName = "seq"
+
+ wsk.action.create(seqCompName,
Some(TestUtils.getTestActionFilename("echo.js")))
+
+ assetHelper.withCleaner(wsk.action, seqName) { (action, seqName) =>
+ action.create(seqName, Some(seqCompName), kind = Some("sequence"))
+ }
+
+ wsk.action.delete(seqCompName)
+
+ retry {
+ (withActivation(wsk.activation, wsk.action.invoke(seqName)) {
activation =>
+ activation.response.result shouldBe Some(JsObject("error" ->
sequenceComponentNotFound.toJson))
+ })
Review comment:
Why is the retry needed here? `withActivation` already does the polling I
think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
