markusthoemmes commented on a change in pull request #3829: Introduce SPI to 
swap authentication directives
URL: 
https://github.com/apache/incubator-openwhisk/pull/3829#discussion_r202065441
 
 

 ##########
 File path: core/controller/src/main/scala/whisk/core/controller/RestAPIs.scala
 ##########
 @@ -191,36 +194,38 @@ class RestAPIVersion(config: WhiskConfig, apiPath: 
String, apiVersion: String)(
         "swagger_paths" -> JsObject("ui" -> s"/$swaggeruipath".toJson, 
"api-docs" -> s"/$swaggerdocpath".toJson)))
   }
 
-  def routes(implicit transid: TransactionId): Route = {
+  def routes(implicit transid: TransactionId, authStore: AuthStore): Route = {
     prefix {
-      sendCorsHeaders {
-        info ~ basicAuth(validateCredentials) { user =>
-          namespaces.routes(user) ~
-            pathPrefix(Collection.NAMESPACES) {
-              actions.routes(user) ~
-                triggers.routes(user) ~
-                rules.routes(user) ~
-                activations.routes(user) ~
-                packages.routes(user)
-            }
-        } ~ {
-          swaggerRoutes
-        }
-      } ~ {
-        // web actions are distinct to separate the cors header
-        // and allow the actions themselves to respond to options
-        basicAuth(validateCredentials) { user =>
-          web.routes(user)
+      extractRequest { httpRequest =>
 
 Review comment:
   Why is this needed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to