remore commented on issue #3725: Add Ruby2.5 runtime support
URL: 
https://github.com/apache/incubator-openwhisk/pull/3725#issuecomment-404754612
 
 
   > are you able to do this small change and we can get it merged?
   
   Yes for sure, I have just made a few changes to get everything organized in 
the ruby-actions.md.
   Thank you for shedding the light on this. @jthomas 
   
   > make sure the ruby runtime repo adopts and passes the basic runtimes test 
suite
   
   Here is the log output of test code which is executed in my laptop with the 
latest code today just FYI @rabbah 
   ```
   vagrant@ubuntu-xenial:~/openwhisk-runtime-ruby$ ./gradlew :tests:test 
--tests *actionContainers.Ruby25ActionContainerTests*
   
   > Task :tests:test
   
   runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 
should run a RUBY script STANDARD_OUT
       test router? false
   
   runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 
should run a RUBY script PASSED
   
   runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 
should run and report an error for script not returning a json object PASSED
   
   runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 
should run a RUBY action and handle unicode in source, input params, logs, and 
result PASSED
   
   runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 
should run a RUBY script and confirm expected environment variables PASSED
   
   runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 
should fail to initialize with bad code PASSED
   
   runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 
should fail to initialize with no code PASSED
   
   runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 
should return some error on action error PASSED
   
   runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 
should support application errors PASSED
   
   runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 
should fail gracefully when an action has a TypeError exception PASSED
   
   runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 
should support the documentation examples (1) PASSED
   
   runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 
should have mechanize and activesupport gems available PASSED
   
   runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 
should support large-ish actions PASSED
   
   runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 
should support zip-encoded packages PASSED
   
   runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 
should fail gracefully on invalid zip files PASSED
   
   runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 
should fail gracefully on valid zip files that are not actions PASSED
   
   runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 
should fail gracefully on valid zip files with invalid code in main.rb PASSED
   
   runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 
should support actions using non-default entry point PASSED
   
   runtime.actionContainers.Ruby25ActionContainerTests > action-ruby-v2.5 
should support zipped actions using non-default entry point PASSED
   
   
   BUILD SUCCESSFUL in 48s
   3 actionable tasks: 1 executed, 2 up-to-date
   ```
   
   > move the runtime remote to an apache repo (requires INFRA to create the 
repo)
   
   I'm willing to proceed with [these 
steps](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87296917)
 only if I'm eligible. If so, please let me know.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to