rabbah closed pull request #3874: Fix warnings in python scripts.
URL: https://github.com/apache/incubator-openwhisk/pull/3874
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tools/build/citool b/tools/build/citool
index 2af93423b4..d9f218e551 100755
--- a/tools/build/citool
+++ b/tools/build/citool
@@ -38,10 +38,10 @@ import time
import traceback
import argparse
if sys.version_info.major >= 3:
- from http.client import HTTPConnection, HTTPSConnection, IncompleteRead,
TEMPORARY_REDIRECT, OK
+ from http.client import HTTPConnection, HTTPSConnection,
TEMPORARY_REDIRECT, OK
from urllib.parse import urlparse
else:
- from httplib import HTTPConnection, HTTPSConnection, IncompleteRead,
TEMPORARY_REDIRECT, OK
+ from httplib import HTTPConnection, HTTPSConnection, TEMPORARY_REDIRECT, OK
from urlparse import urlparse
import re
import threading
diff --git a/tools/build/redo b/tools/build/redo
index 941104d3f3..b421a18d22 100755
--- a/tools/build/redo
+++ b/tools/build/redo
@@ -278,12 +278,12 @@ Components = [
'build a runtime action container, matching name using the
regex; NOTE: must use --dir for path to runtime directory',
yaml = False,
gradle = 'core:$1:distDocker'),
-
- makeComponent('actionproxy',
- 'build action proxy container',
- yaml = False,
+
+ makeComponent('actionproxy',
+ 'build action proxy container',
+ yaml = False,
gradle = 'tools:actionProxy'),
-
+
# required for tests
makeComponent('props',
'build whisk.properties file (required for tests)',
diff --git a/tools/travis/flake8.sh b/tools/travis/flake8.sh
index 23aab8285c..7edddaa1f6 100755
--- a/tools/travis/flake8.sh
+++ b/tools/travis/flake8.sh
@@ -30,13 +30,13 @@ do
flake8 "$i" --select=E999,F821 --statistics
RETURN_CODE=$?
if [ $RETURN_CODE != 0 ]; then
- echo 'Flake8 found Python 3 syntax errors above. See:
https://docs.python.org/3/howto/pyporting.html'
+ echo 'Flake8 found Python 3 syntax errors above. See:
https://docs.python.org/3/howto/pyporting.html'
exit $RETURN_CODE
fi
done
-echo 'Flake8: second round uses the --exit-zero flag to treat _every_ message
as a warning...'
+echo 'Flake8: second round to find any other stylistic issues...'
for i in "${PYTHON_FILES[@]}"
do
- flake8 "$i" --ignore=E --max-line-length=127 --statistics --exit-zero
+ flake8 "$i" --ignore=E --max-line-length=127 --statistics
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services