bbrowning opened a new pull request #3878: Validate the Controller Swagger spec 
matches the impl
URL: https://github.com/apache/incubator-openwhisk/pull/3878
 
 
   
   <!--- Provide a concise summary of your changes in the Title -->
   
   ## Description
   <!--- Provide a detailed description of your changes. -->
   <!--- Include details of what problem you are solving and how your changes 
are tested. -->
   
   This change wires up all existing API tests that use WskRestOperations to 
validate the HTTP requests and responses against the Controller API's Swagger 
spec.
   
   It also adds a new Gradle task - :tests:testSwaggerCodegen - that does a 
basic validation of the Swagger spec and generates a basic Java client from 
that spec and verifies that the client compiles. CI is wired up to run this new 
test task.
   
   The result of both of the above are a number of changes to the Swagger spec, 
also included here. This brings our Swagger spec much closer to matching the 
reality of the Controller API, and any additional coverage in the API test 
suite will further increase coverage of the Swagger spec.
   
   There are some existing tests that purposely test API responses when passed 
invalid data, so the new SwaggerValidator trait includes a small whilelist of 
invalid requests and responses to accept so the build does not fail in these 
scenarios.
   
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   
http://mail-archives.apache.org/mod_mbox/openwhisk-dev/201806.mbox/%3CCAOpbpxHbSOdPpdR5t-WWTKkrTyuP%2B1c3_qeMY7vrhkfXmBYcQw%40mail.gmail.com%3E
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [x] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [x] Tests
   - [ ] Deployment
   - [ ] CLI
   - [x] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the 
boxes that apply: -->
   - [x] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered 
all aspects of the change you're making. -->
   
   - [x] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [x] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to