markusthoemmes commented on a change in pull request #3878: Validate the 
Controller Swagger spec matches the impl
URL: 
https://github.com/apache/incubator-openwhisk/pull/3878#discussion_r202479910
 
 

 ##########
 File path: tests/src/test/scala/common/rest/WskRestOperations.scala
 ##########
 @@ -1188,7 +1189,20 @@ trait RunRestCmd extends Matchers with ScalaFutures {
       hostWithScheme.withPath(path).withQuery(Query(params)),
       List(Authorization(creds)),
       entity = body.map(b => HttpEntity(ContentTypes.`application/json`, 
b)).getOrElse(HttpEntity.Empty))
-    Http().singleRequest(request, connectionContext).futureValue
+    val response = Http().singleRequest(request, connectionContext).futureValue
 
 Review comment:
   I wonder if it would be fine to create the `HttpRequest` entity with 
`HttpEntity.Strict` and call `toStrict` on the response entity straight away. 
Would that spare you the hassle of having to copy the response and pass both 
bodies seperately to the validate method?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to