ningyougang edited a comment on issue #3619: Provide an activation store SPI
URL: 
https://github.com/apache/incubator-openwhisk/pull/3619#issuecomment-406547593
 
 
   ### 1. Why need to write a new ActivationStoreProvider for `elasticsearch`?
   Currently, `activations` are saved into `couchdb` using 
`ArtifactActivationStore`
   
   couchdb has below disadvantage for saving activations
   *  It is not convenience to  `delete big activations`(activation data is 
growing very fast on production env, when disk is full, need to delete, but 
should do compression at first, otherwise, disk usage will increase) 
   * Couchdb's search feature is not stronger than `elasticsearch`.
   
   Since we provide `Provide an activation store SPI` in this patch, so i think 
it is necessary to implement a new ActivationStoreProvider  for `elasticsearch`
   
   ### 2.How to implement it?
   * Implement this trait `ActivationStore`, for example:
   ```
   class ElasticsearchActivationStore(actorSystem: ActorSystem, 
actorMaterializer: ActorMaterializer, logging: Logging) extends ActivationStore
   ```
   * In class ElasticsearchActivationStore inner, we can use 
`https://github.com/sksamuel/elastic4s/` to implement it.
   
   @markusthoemmes ,how do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to