markusthoemmes commented on a change in pull request #3698: Make amount of
parallel docker runs configurable.
URL:
https://github.com/apache/incubator-openwhisk/pull/3698#discussion_r204344176
##########
File path: core/invoker/src/main/resources/application.conf
##########
@@ -10,6 +10,14 @@ whisk {
poll-interval: 5 minutes
}
+ # Docker < 1.13.1 has a known problem: if more than 10 containers are
created (docker run)
+ # concurrently, there is a good chance that some of them will fail.
+ # See https://github.com/moby/moby/issues/29369
+ # Use a semaphore to make sure that at most 10 `docker run` commands are
active
+ # the same time.
+ # 0 means that there are infinite parallel runs.
+ docker.parallel-runs: 10
Review comment:
Should we refactor the config a bit? I'm envisioning something like:
```
docker.client {
parallel-runs: 10,
timeouts {
..
}
}
```
Which would change the code to:
```scala
case class DockerClientConfig(parallelRuns: Int, timeouts:
DockerClientTimeoutConfig)
```
And makes it a bit more clean in general. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
