mhenke1 commented on a change in pull request #3892: Use the authz provider to 
retrieve the identity of the namespace
URL: 
https://github.com/apache/incubator-openwhisk/pull/3892#discussion_r204431717
 
 

 ##########
 File path: core/controller/src/main/scala/whisk/core/controller/RestAPIs.scala
 ##########
 @@ -320,7 +320,28 @@ class RestAPIVersion(config: WhiskConfig, apiPath: 
String, apiVersion: String)(
 }
 
 trait AuthenticationDirectiveProvider extends Spi {
+
+  /**
+   * Returns an authentication directive used to validate the
+   * passed user credentials.
+   * At runtime the directive returns an user identity
+   * which is passed to the following routes
+   *
+   * @return autehtication directive used to verify the user credentials
+   */
   def authenticate(implicit transid: TransactionId,
                    authStore: AuthStore,
                    logging: Logging): AuthenticationDirective[Identity]
+
+  /**
+   * Retrieves an Identity based on a given namespace name.
+   *
+   * For use-cases of anonymous invocation (i.e. WebActions),
+   * we need to an identity based on a given namespace-name to
+   * give the invocation all the context needed.
+   * @param namespace the namespace that the identity will be based on
 
 Review comment:
   Thx. Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to