rabbah commented on a change in pull request #1: Adding initial sources for Ballerina runtime URL: https://github.com/apache/incubator-openwhisk-runtime-ballerina/pull/1#discussion_r204442080
########## File path: README.md ########## @@ -1 +1,117 @@ -# incubator-openwhisk-runtime-ballerina +<!-- +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +--> + +# Apache OpenWhisk Runtime for Ballerina Review comment: This is a good README and better IMO than the build only instructions we have in the other runtime repos. We should include instructions however for how to locally build and test this runtime image. See other runtimes as an example. I suggest having two main sections therefore to the readme: 1. build and test (which you are missing), 2. how to use as an action runtime (which you know have). Slowly we should do the same for all the other runtimes. cc @csantanapr ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
