tysonnorris commented on a change in pull request #3743: Fixes #3742 - just
remove the time range part of the query, each acti…
URL:
https://github.com/apache/incubator-openwhisk/pull/3743#discussion_r204459966
##########
File path:
common/scala/src/main/scala/whisk/core/containerpool/logging/SplunkLogStore.scala
##########
@@ -112,11 +112,7 @@ class SplunkLogStore(
Map(
"exec_mode" -> "oneshot",
"search" -> search,
- "output_mode" -> "json",
- "earliest_time" -> activation.start.toString, //assume that activation
start/end are UTC zone, and splunk events are the same
- "latest_time" -> activation.end
- .plusSeconds(5) //add 5s to avoid a timerange of 0 on short-lived
activations
- .toString)).toEntity
+ "output_mode" -> "json")).toEntity
Review comment:
I think the "no results" case also needs to be handled, regardless of
whether the query is correct.
It is still not clear why the timestamp queries wouldn't work - my concern
is that this could be problematic depending on the config of the splunk index;
do you have example logs and queries where this fails?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
