rabbah commented on a change in pull request #3813: Recover image pulls by 
trying to run the container anyways.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3813#discussion_r204483169
 
 

 ##########
 File path: 
core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainer.scala
 ##########
 @@ -104,22 +102,44 @@ object DockerContainer {
       dnsServers.flatMap(d => Seq("--dns", d)) ++
       name.map(n => Seq("--name", n)).getOrElse(Seq.empty) ++
       params
-    val pulled = if (userProvidedImage) {
-      docker.pull(image).recoverWith {
-        case _ => 
Future.failed(BlackboxStartupError(Messages.imagePullError(image)))
-      }
-    } else Future.successful(())
+
+    val imageToUse = image.fold(_.publicImageName, identity)
+
+    val pulled = image match {
+      case Left(userProvided) if userProvided.tag.map(_ == 
"latest").getOrElse(true) =>
+        // Iff the image tag is "latest" explicitly (or implicitly because no 
tag is given at all), failing to pull will
+        // fail the whole container bringup process, because it is expected to 
pick up the very latest version every
+        // time.
 
 Review comment:
   the very latest "untagged" version every time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to