markusthoemmes commented on a change in pull request #3656: Adjust the 
ForcibleSemaphore mechanism 
URL: 
https://github.com/apache/incubator-openwhisk/pull/3656#discussion_r206108591
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/common/ForcableSemaphore.scala
 ##########
 @@ -34,7 +34,7 @@ import scala.annotation.tailrec
  *
  * @param maxAllowed maximum number of permits given away by `tryAcquire`
  */
-class ForcableSemaphore(maxAllowed: Int) {
+class ForcableSemaphore(private var maxAllowed: Int) {
 
 Review comment:
   Does this need to be volatile now?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to