dgrove-oss commented on a change in pull request #265: Add alarm provider URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/265#discussion_r206700925
########## File path: helm/providers/charts/alarm/README.md ########## @@ -0,0 +1,43 @@ +<!-- +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +--> + +# Use Helm to deploy alarm provider and package + +This chart is to deploy alarm provider and package to OpenWhisk on a Kubernetes using Helm. + +## Preconditions + +Alarm package can only be successfully installed under these two preconditions: ++ persistentvolumes (aka 'pv') is defined in your Kubernetes cluster. You can verify by `kubectl get pv`. ++ `KubernetesContainerFactory` is used as the [Invoker Container Factory](https://github.com/apache/incubator-openwhisk-deploy-kube/blob/master/docs/configurationChoices.md#invoker-container-factory) in your Kubernetes cluster. In order to do that, you can add below configuration in your `mycluster.yaml` when you are deploying OpenWhisk with Helm: +``` Review comment: Interesting; I wouldn't have expected a dependency on the container factory implementation. Where does it come from? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
