chetanmeh commented on issue #3958: Add tracing component name to wskadmin-next
URL: 
https://github.com/apache/incubator-openwhisk/pull/3958#issuecomment-411763212
 
 
   @markusthoemmes This is due to how currently tracing is configured. It 
requires a component name which is provided via config. For example Invoker 
provides it like below 
   
   
https://github.com/apache/incubator-openwhisk/blob/79e72e641703b4138cc58bc6bf0d5863a8fe6919/core/invoker/src/main/resources/application.conf#L71-L74
   
   And similarly Controller provides it in its config. So each new module would 
need to provide this. Other option can be that we provide a default value in 
common reference.conf 
   
   
https://github.com/apache/incubator-openwhisk/blob/f593de8614cf51c84ed7e78b27e93f64cda72c75/common/scala/src/main/resources/application.conf#L207-L219
   
   The other module can choose to override it if needed. 
   
   So we can either keep current fix or do above change. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to