rabbah commented on a change in pull request #3950: Extend system testsuite
URL:
https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r209888951
##########
File path: tests/src/test/scala/common/rest/WskRestOperations.scala
##########
@@ -707,18 +709,21 @@ class RestActivationOperations(implicit val actorSystem:
ActorSystem)
* @param entity the name of the entity to filter from activation list
* @param limit the maximum number of entities to list (if entity name is
not unique use Some(0))
* @param since (optional) only the activations since this timestamp are
included
+ * @param skip (optional) the number of activations to skip
* @param retries the maximum retries (total timeout is retries + 1 seconds)
* @return activation ids found, caller must check length of sequence
*/
override def pollFor(N: Int,
entity: Option[String],
limit: Option[Int] = Some(30),
since: Option[Instant] = None,
+ skip: Option[Int] = Some(0),
Review comment:
Same q why is default some 0 not none.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
