style95 commented on a change in pull request #3671: Activation id in header
URL:
https://github.com/apache/incubator-openwhisk/pull/3671#discussion_r210958917
##########
File path: core/controller/src/main/scala/whisk/core/controller/Entities.scala
##########
@@ -65,15 +65,24 @@ protected[controller] trait ValidateRequestSize extends
Directives {
protected val fieldDescriptionForSizeError = "Request"
}
+protected trait CustomHeaders extends Directives {
+ val ActivationIdHeader = "x-openwhisk-activation-id"
Review comment:
@rabbah Agree.
How about using x-openwhisk?
Since x- header is a custom header specific to the application, it would be
better to use the detailed one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
