vvraskin commented on a change in pull request #3999: Mark activationRun as
failed if there is an ContainerConnectionError
URL:
https://github.com/apache/incubator-openwhisk/pull/3999#discussion_r214727118
##########
File path: common/scala/src/main/scala/whisk/core/containerpool/Container.scala
##########
@@ -142,12 +142,16 @@ trait Container {
callContainer("/run", body, timeout, retry = false)
.andThen { // never fails
case Success(r: RunResult) =>
Review comment:
Did you consider adding a similar behaviour for the `/init` call as well? I
see nearly the same code in
https://github.com/apache/incubator-openwhisk/blob/master/common/scala/src/main/scala/whisk/core/containerpool/Container.scala#L102
or maybe even extracting it into a separate method would help here...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
