jiangpengcheng commented on a change in pull request #3999: Mark activationRun
as failed if there is an ContainerConnectionError
URL:
https://github.com/apache/incubator-openwhisk/pull/3999#discussion_r214857411
##########
File path: common/scala/src/main/scala/whisk/core/containerpool/Container.scala
##########
@@ -142,12 +142,16 @@ trait Container {
callContainer("/run", body, timeout, retry = false)
.andThen { // never fails
case Success(r: RunResult) =>
- transid.finished(
- this,
- start.copy(start = r.interval.start),
- s"running result: ${r.toBriefString}",
- endTime = r.interval.end,
- logLevel = InfoLevel)
+ r.response match {
+ case Left(_) => transid.failed(this, start, s"run failed with
${r.toBriefString}", logLevel = ErrorLevel)
Review comment:
ok, but that should be marked as error too in my opinion , as the activation
is failed anyway
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
