dubee commented on a change in pull request #4033: Remove Artifact Store
Polling for Blocking Invocations
URL:
https://github.com/apache/incubator-openwhisk/pull/4033#discussion_r218914987
##########
File path:
common/scala/src/main/scala/whisk/core/containerpool/AkkaContainerClient.scala
##########
@@ -162,7 +162,7 @@ protected class AkkaContainerClient(
} else {
//ignore the tail (MUST CONSUME ENTIRE ENTITY!)
//captured string MAY be larger than the max response, so take only
maxResponse bytes to get the exact length
- tail.runWith(Sink.ignore).map(_ =>
truncatedResponse.take(maxResponse.toBytes.toInt).utf8String)
+ tail.runWith(Sink.ignore).map(_ =>
truncatedResponse.take(maxResponse.toBytes.toInt - 1024).utf8String)
Review comment:
For truncation, we need to account for bytes that are added to the message
when the Kafka producer serializes the message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
