csantanapr commented on a change in pull request #57: Multi arch test
URL:
https://github.com/apache/incubator-openwhisk-runtime-go/pull/57#discussion_r228509252
##########
File path: examples/golang-hello-vendor/Makefile
##########
@@ -17,10 +17,10 @@ devel: package.done $(SRCZIP)
$(WSK) action update $(PACKAGE)/$(NAME) $(SRCZIP) --main $(MAIN)
--docker $(OW_COMPILER)
src/%/vendor:
- cd $(@D) ; GOPATH=$$(realpath $$PWD/../..) dep ensure
+ cd $(@D) ; DEPPROJECTROOT=$(realpath $(@D)/../..) dep ensure
-$(BINZIP): $(SRCS) $(VENDORS)
- cd src ; zip - -r * | docker run -i $(OW_COMPILER) -compile $(MAIN)
>../$(BINZIP)
+$(BINZIP): $(SRCS) $(VENDORS) $(SRCZIP)
+ docker run -i $(OW_COMPILER) -compile $(MAIN) <$(SRCZIP) >$(BINZIP)
Review comment:
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
