sven-lange-last commented on a change in pull request #4090: upgrade from
docker 1.12 to 18.06
URL:
https://github.com/apache/incubator-openwhisk/pull/4090#discussion_r229585506
##########
File path: ansible/group_vars/all
##########
@@ -175,7 +175,7 @@ invoker:
# Specify if it is allowed to deploy more than 1 invoker on a single machine.
allowMultipleInstances: "{{ invoker_allow_multiple_instances |
default(false) }}"
# Specify if it should use docker-runc or docker to pause/unpause containers
- useRunc: "{{ invoker_use_runc | default(true) }}"
+ useRunc: "{{ invoker_use_runc | default(false) }}"
Review comment:
I suggest to add a comment here that we suspect / know (?) that the runc
support does not work properly with Docker 18.06.1-ce. Otherwise people may be
tempted to switch it on.
And probably we should either invest to understand why runc support does not
work and repair it or retire runc support because it does not work any more
with recent Docker CE versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
