tysonnorris commented on a change in pull request #4109: update mesos-actor;
cleanup orphaned failed task launches
URL:
https://github.com/apache/incubator-openwhisk/pull/4109#discussion_r233036814
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/mesos/MesosTask.scala
##########
@@ -142,9 +140,14 @@ object MesosTask {
transid.finished(this, start, s"launched task ${taskId} at
${taskDetails.hostname}:${taskDetails
.hostports(0)}", logLevel = InfoLevel)
case Failure(ate: AskTimeoutException) =>
- transid.failed(this, start, ate.getMessage, ErrorLevel)
+ transid.failed(this, start, s"task launch timed out
${ate.getMessage}", ErrorLevel)
MetricEmitter.emitCounterMetric(LoggingMarkers.INVOKER_MESOS_CMD_TIMEOUT(LAUNCH_CMD))
- case Failure(t) => transid.failed(this, start, t.getMessage,
ErrorLevel)
+ //kill the task whose launch timed out
+ destroy(mesosClientActor, mesosConfig, taskId)
+ case Failure(t) =>
+ //kill the task whose launch timed out
+ destroy(mesosClientActor, mesosConfig, taskId)
Review comment:
In this case destroy is just cleanup that is mesos-specific, so it should
happen independent of the create future; i.e. `create()` timeout should return
immediately, but trigger the cleanup of `destroy()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
