dubee commented on a change in pull request #4141: Use Stricter Retry Logic in
ApacheBlockingContainerClient
URL:
https://github.com/apache/incubator-openwhisk/pull/4141#discussion_r237238880
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/ApacheBlockingContainerClient.scala
##########
@@ -149,11 +152,13 @@ protected class ApacheBlockingContainerClient(hostname:
String,
} match {
case Success(response) => response
case Failure(t: RetryableConnectionError) if retry =>
+ val waitTime = (Instant.now.toEpochMilli -
start.toEpochMilli).milliseconds
val sleepTime = 50.milliseconds
if (timeout > Duration.Zero) {
Thread.sleep(sleepTime.toMillis)
- val newTimeout = timeout - sleepTime
- execute(request, newTimeout, maxConcurrent, retry = true)
+ val newTimeout = timeout - sleepTime - waitTime
+ val newRetryCount = retryCount + 1
+ execute(request, newTimeout, maxConcurrent, retry = newRetryCount <
3 , retryCount = newRetryCount)
Review comment:
Three may be too low of a threshold?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
