dubee commented on a change in pull request #4088: Make activation polling for
blocking invocations configurable
URL:
https://github.com/apache/incubator-openwhisk/pull/4088#discussion_r237663515
##########
File path:
core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala
##########
@@ -593,11 +596,15 @@ protected[actions] trait PrimitiveActions {
// in case of an incomplete active-ack (record too large for example).
activeAckResponse.foreach {
case Right(activation) => result.trySuccess(Right(activation))
- case _ => pollActivation(docid, context, result, i =>
1.seconds + (2.seconds * i), maxRetries = 4)
+ case _ if (controllerActivationConfig.pollingFromDb) =>
+ pollActivation(docid, context, result, i => 1.seconds + (2.seconds *
i), maxRetries = 4)
Review comment:
After rebasing it looks the two active ack changes no longer required DB
polling.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
