dgrove-oss commented on a change in pull request #381: fix dangling links to
docs/ingress.md (was split into multiple files).
URL:
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/381#discussion_r238007888
##########
File path: helm/openwhisk/templates/ow-whisk-cm.yaml
##########
@@ -1,15 +1,6 @@
# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
# license agreements; and to You under the Apache License, Version 2.0.
-# There are some variables that a user must define for their deployment.
-# Check for those values here and attempt to give helpful error messages.
-#
-{{- if ne .Values.whisk.ingress.type "LoadBalancer" }}
-# whisk.ingress.type is {{ required "You must provide a value for
whisk.ingress.type (See docs/ingress.md)" .Values.whisk.ingress.type }}
-# whisk.ingress.apiHostName is {{ required "You must provide a value for
whisk.ingress.apiHostName (See docs/ingress.md)"
.Values.whisk.ingress.apiHostName }}
-# whisk.ingress.apiHostPort is {{ required "You must provide a value for
whisk.ingress.apiHostPort (See docs/ingress.md)"
.Values.whisk.ingress.apiHostPort }}
-{{- end }}
-
Review comment:
Note to reviewer: these tests were no longer functional. We now provide
default values for every variable in values.yaml to pass `helm lint`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
