tysonnorris commented on a change in pull request #4142: tools/dev - updated intellij script to accommodate docker-compose URL: https://github.com/apache/incubator-openwhisk/pull/4142#discussion_r238084798
########## File path: core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/docker/DockerForMacContainerFactory.scala ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.openwhisk.core.containerpool.docker + +import akka.actor.ActorSystem +import org.apache.openwhisk.common.{Logging, TransactionId} +import org.apache.openwhisk.core.WhiskConfig +import org.apache.openwhisk.core.containerpool._ +import org.apache.openwhisk.core.entity.InvokerInstanceId + +import scala.concurrent.{ExecutionContext, Future} +import scala.concurrent.duration._ + +/** + * This factory provides a Docker for Mac client which exposes action container's ports on the host. + */ +object DockerForMacContainerFactoryProvider extends ContainerFactoryProvider { + override def instance(actorSystem: ActorSystem, + logging: Logging, + config: WhiskConfig, + instanceId: InvokerInstanceId, + parameters: Map[String, Set[String]]): ContainerFactory = { + + new DockerContainerFactory(instanceId, parameters)( Review comment: It would be handle to fail here if there is a missing config to disable runc: `whisk.docker.container-factory.use-runc=False` (should be required for docker for mac, I think) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
