mhenke1 commented on a change in pull request #4149: Do not link the 
`/run/runc` volume unless invoker_use_runc is set
URL: 
https://github.com/apache/incubator-openwhisk/pull/4149#discussion_r238273802
 
 

 ##########
 File path: ansible/roles/invoker/tasks/deploy.yml
 ##########
 @@ -262,12 +262,17 @@
 
 - name: set invoker volumes
   set_fact:
-    volumes: "/sys/fs/cgroup:/sys/fs/cgroup,/run/runc:/run/runc,\
+    volumes: "/sys/fs/cgroup:/sys/fs/cgroup,\
       {{ whisk_logs_dir }}/{{ invoker_name }}:/logs,\
       {{ invoker.confdir }}/{{ invoker_name }}:/conf,\
       {{ dockerInfo['DockerRootDir'] }}/containers/:/containers,\
       {{ docker_sock | default('/var/run/docker.sock') }}:/var/run/docker.sock"
 
+- name: set invoker runc volume
+  set_fact:
+    volumes: "{{ volumes }},/run/runc:/run/runc"
+  when: invoker_use_runc == true
 
 Review comment:
   `invoker_use_runc`is not reachable here. 
   it probably should be `when: invoker.useRunc == true`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to