mdeuser commented on a change in pull request #388: Save Code Associated with 
Blackbox Actions
URL: 
https://github.com/apache/incubator-openwhisk-cli/pull/388#discussion_r238345231
 
 

 ##########
 File path: commands/action.go
 ##########
 @@ -692,7 +692,7 @@ func saveCode(action whisk.Action, filename string) (err 
error) {
        exec = *action.Exec
        runtime = strings.Split(exec.Kind, ":")[0]
 
-       if strings.ToLower(runtime) == BLACKBOX {
+       if strings.ToLower(runtime) == BLACKBOX && exec.Code == nil && 
*exec.Binary == false {
 
 Review comment:
   yeah.. thinking this is equivalent
   ```
        if strings.ToLower(runtime) == BLACKBOX && exec.Code == nil && 
*exec.Binary == false {
                return cannotSaveImageError()
        }
   
           if strings.ToLower(runtime) == SEQUENCE {
                return cannotSaveSequenceError()
           }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to